widelands-dev team mailing list archive

[Klaus Halfmann <klaus.halfmann@xxxxxxxx>]

Review: Approve review

Going to review this now, found:

"sew better armor" -> "sew sturdier garments"
"constructionsite" -> "cronstruction site"
"Build a recruitment center" -> "Start recruiting soldiers"
"But meanwhile, we can start -> "However, we can already start"
"what your business you have" -> "what business you have"
"Salve amicus Imperii!" -> "Salvete amici Imperii!",

More politeness :-)
Better plural of enemy.
Fixing "false friends" 
* Kann != can 
* Oder ~= Or

Moral:
* I should really try to play that second scenario again, looks like I missed some intersting parts here.
* It really helps to have native English speakers.
* A knowledge of Latin helps, too :-)

Benedikt: about those false friends: I hear them at work every day :-)
GunChleoc: One comment inline, you may decide if you want to fix it.

I am about to compile this now but see no need for a testplay.

Diff comments:

> 
> === modified file 'data/campaigns/fri02.wmf/scripting/texts.lua'
> --- data/campaigns/fri02.wmf/scripting/texts.lua	2018-03-18 19:48:31 +0000
> +++ data/campaigns/fri02.wmf/scripting/texts.lua	2018-05-06 06:35:33 +0000
> @@ -73,7 +73,8 @@
>        li(_"20 × Iron") ..
>        li(_"30 × Gold Ore") ..
>        li(_"10 × Gold") ..
> -      p(_([[Or just destroy the warehouse and risk having Murilius as an enemy. He forbade you to expand your territory until the wares have been handed over.]]))
> +      -- TRANSLATORS: Continues from "Decide whether you want to work with Murilius against the Barbarians. If so, fill his warehouse with these wares: [list of weares]"

List of weares -> List of wares

> +      p(_([[Otherwise, just destroy the warehouse and risk having Murilius as an enemy. He forbade you to expand your territory until the wares have been handed over.]]))
>     ),
>  }
>  obj_defeat_barbarians = {


-- 
https://code.launchpad.net/~widelands-dev/widelands/frisian-campaign-string-fixes/+merge/345136
Your team Widelands Developers is subscribed to branch lp:~widelands-dev/widelands/frisian-campaign-string-fixes.