widelands-dev team mailing list archive

[Klaus Halfmann <klaus.halfmann@xxxxxxxx>]

Review: Approve review, compile, test

Can reproduce the bug. 

Do we have a ticket for this on?
> ERROR: Unused key "1" in LuaTable. Please report as a bug.
> ERROR: Unused key "2" in LuaTable. Please report as a bug.

Found: Bug is fixed.

Please check my inline comments fors gloabal side effects.
 

Diff comments:

> 
> === modified file 'src/ui_basic/multilineeditbox.cc'
> --- src/ui_basic/multilineeditbox.cc	2018-04-07 16:59:00 +0000
> +++ src/ui_basic/multilineeditbox.cc	2018-05-12 05:41:58 +0000
> @@ -209,6 +209,17 @@
>  }
>  
>  /**
> + * The mouse was clicked on this editbox

Default action: focus if possible, please call super oninclude this in case of an override.

> +*/
> +bool MultilineEditbox::handle_mousepress(const uint8_t btn, int32_t, int32_t) {
> +	if (btn == SDL_BUTTON_LEFT && get_can_focus()) {
> +		focus();
> +		return true;
> +	}
> +	return false;
> +}
> +
> +/**

Uhm, this is a global change, why does it affects that map options only?

>   * This is called by the UI code whenever a key press or release arrives
>   */
>  bool MultilineEditbox::handle_key(bool const down, SDL_Keysym const code) {


-- 
https://code.launchpad.net/~widelands-dev/widelands/bug-1749146-multiline-editbox/+merge/345455
Your team Widelands Developers is subscribed to branch lp:~widelands-dev/widelands/bug-1749146-multiline-editbox.