widelands-dev team mailing list archive

[GunChleoc <fios@xxxxxxxxxxxxxxxxxxx>]

Thanks for the review :)

I noticed the error messages too, we don't have a bug for them yet.

@bunnybot merge

Diff comments:

> 
> === modified file 'src/ui_basic/multilineeditbox.cc'
> --- src/ui_basic/multilineeditbox.cc	2018-04-07 16:59:00 +0000
> +++ src/ui_basic/multilineeditbox.cc	2018-05-12 05:41:58 +0000
> @@ -209,6 +209,17 @@
>  }
>  
>  /**
> + * The mouse was clicked on this editbox

Panel::handle_mousepress does something here that we don't want, so no, not a good idea in this case ;)

If we want to change that, it would mean a big redesign of all panels, and I don't want to go there right now.

> +*/
> +bool MultilineEditbox::handle_mousepress(const uint8_t btn, int32_t, int32_t) {
> +	if (btn == SDL_BUTTON_LEFT && get_can_focus()) {
> +		focus();
> +		return true;
> +	}
> +	return false;
> +}
> +
> +/**

Because we don't use Multilineeditbox anywhere else at the moment.

>   * This is called by the UI code whenever a key press or release arrives
>   */
>  bool MultilineEditbox::handle_key(bool const down, SDL_Keysym const code) {


-- 
https://code.launchpad.net/~widelands-dev/widelands/bug-1749146-multiline-editbox/+merge/345455
Your team Widelands Developers is subscribed to branch lp:~widelands-dev/widelands/bug-1749146-multiline-editbox.