widelands-dev team mailing list archive

[Notabilis <notabilis27@xxxxxx>]

I am not quite convinced of this branch, since it only solves the problem partially.

In trunk:
- Hotkey like Ctrl+1 and "s" do not work
- Arrow keys do not work
- Enter key closes the minimized window
In this branch:
- Hotkeys work
- Arrow keys still do not work
- Enter key does nothing on first press, closes window on second press

The working hotkeys are nice, additionally working arrow keys would be even better. And the behavior of the enter key is quite strange, no idea where that is coming from. A suggestion independent of the current behavior: Maximize chat window on enter key when currently minimized instead of closing it?

For what it's worth: Code is looking good.
-- 
https://code.launchpad.net/~widelands-dev/widelands/bug-1627374-chat-input/+merge/345457
Your team Widelands Developers is requested to review the proposed merge of lp:~widelands-dev/widelands/bug-1627374-chat-input into lp:widelands.