widelands-dev team mailing list archive

Thread
Date

Re: [Merge] lp:~widelands-dev/widelands/bug-1636586-editor-player-menu-i18n into lp:widelands

To: mp+345464@xxxxxxxxxxxxxxxxxx
From: Notabilis <notabilis27@xxxxxx>
Date: Mon, 14 May 2018 18:05:42 -0000
In-reply-to: <152614670158.9433.14467201081574369279.launchpad@ackee.canonical.com>
Reply-to: mp+345464@xxxxxxxxxxxxxxxxxx
Sender: bounces@xxxxxxxxxxxxx

Review: Approve diff

Not tested but code is looking good.
One question: Why checking for both the localized and "plain" name variant when saving? In English they should resolve to the same name anyway (right?) and I don't see where the plain version can appear otherwise.
-- 
https://code.launchpad.net/~widelands-dev/widelands/bug-1636586-editor-player-menu-i18n/+merge/345464
Your team Widelands Developers is subscribed to branch lp:~widelands-dev/widelands/bug-1636586-editor-player-menu-i18n.

References

[Merge] lp:~widelands-dev/widelands/bug-1636586-editor-player-menu-i18n into lp:widelands
From: GunChleoc, 2018-05-12