← Back to team overview

widelands-dev team mailing list archive

Re: [Merge] lp:~widelands-dev/widelands/campaign_data into lp:widelands

 

Review: Needs Fixing regresson test

Oops this crashes on OSX when running the regression tests:

test/maps/plain.wmf/scripting/test_campaign_data.lua ... 
  Running Widelands ... FAIL

READ of size 3 at 0x7ffeeb29c1c1 thread T0
    #0 0x109307c34 in wrap_strlen (libclang_rt.asan_osx_dynamic.dylib:x86_64h+0x15c34)
    #1 0x1049e3d04 in boost::range_detail::length(char const*) as_literal.hpp:38
    #2 0x1049e3bf9 in boost::iterator_range<char const*> boost::range_detail::make_range<char const>(char const*, bool) as_literal.hpp:86
    #3 0x106e5794e in boost::iterator_range<boost::range_iterator<char const* const, void>::type> boost::as_literal<char const*>(char const* const&) as_literal.hpp:109
    #4 0x106e58028 in bool boost::algorithm::equals<char const*, char const*, boost::algorithm::is_iequal>(char const* const&, char const* const&, boost::algorithm::is_iequal) predicate.hpp:290
    #5 0x106e49ab6 in bool boost::algorithm::iequals<char const*, char const*>(char const* const&, char const* const&, std::__1::locale const&) predicate.hpp:346
    #6 0x106e496da in Section::has_val(char const*) const profile.cc:216
    #7 0x106a5a3d2 in LuaBases::push_table_recursively(lua_State*, std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char> >, Section*, Section*, Section*, Section*) lua_bases.cc:431
    #8 0x106a56d06 in LuaBases::LuaEditorGameBase::read_campaign_data(lua_State*) lua_bases.cc:488
    #9 0x106bf85ca in int method_dispatch<LuaRoot::LuaGame, LuaBases::LuaEditorGameBase>(lua_State*) luna_impl.h:175
..

  This frame has 7 object(s):
    [32, 56) 'ref.tmp' (line 429) <== Memory access at offset 33 is inside this variable
    [96, 120) 'ref.tmp2' (line 429)
    [160, 184) 'ref.tmp3' (line 429)
...

SUMMARY: AddressSanitizer: stack-use-after-scope (libclang_rt.asan_osx_dynamic.dylib:x86_64h+0x15c34) in wrap_strlen

Benedikt, can you confirm / fix it with this information?
Otherwise I will have to setup a longer debugger session.

-- 
https://code.launchpad.net/~widelands-dev/widelands/campaign_data/+merge/343783
Your team Widelands Developers is subscribed to branch lp:~widelands-dev/widelands/campaign_data.


References