← Back to team overview

widelands-dev team mailing list archive

Re: [Merge] lp:~widelands-dev/widelands/bug-1732765-economy-refactoring into lp:widelands

 

* This depends or includes https://code.launchpad.net/~widelands-dev/widelands/bug-1690519-economy-unique_ptr ?

No, that was a failed attempt at fixing something and will be scrapped once this is merged


* As Serial is uint32_t so we have 2^32 different Economies, ok

I hope that is enough - maybe we need a stress test?


* Do we have a testcase with a lot of Economies to get an Idea of the Performance change?

I don't expect any performance changes really - we access economies from containers in both cases.
-- 
https://code.launchpad.net/~widelands-dev/widelands/bug-1732765-economy-refactoring/+merge/345277
Your team Widelands Developers is requested to review the proposed merge of lp:~widelands-dev/widelands/bug-1732765-economy-refactoring into lp:widelands.


References