← Back to team overview

widelands-dev team mailing list archive

[Merge] lp:~widelands-dev/widelands/bug-1773688-ui-starting-condition into lp:widelands

 

Notabilis has proposed merging lp:~widelands-dev/widelands/bug-1773688-ui-starting-condition into lp:widelands.

Commit message:
Fixing optical ui bugs with setting up scenario games.

Requested reviews:
  Widelands Developers (widelands-dev)
Related bugs:
  Bug #1773688 in widelands: "Starting condition with scenario maps"
  https://bugs.launchpad.net/widelands/+bug/1773688

For more details, see:
https://code.launchpad.net/~widelands-dev/widelands/bug-1773688-ui-starting-condition/+merge/347546

Three changes:
- Displaying start type of players as "Scenario" when selecting a scenario map in single player. In trunk, the previously selected start type (e.g., Headquarters) is still displayed even though it is no longer valid.
- Setting same tooltip for the start type of scenarios in multiplayer. In trunk the tooltype is only set for the players that have been active on the previously selected map.
- Same handling for single player "select map" dialog independent of whether it is reached per "back" or "select map" button. In trunk "select map" kept the settings regarding tribe, etc., while the "back" button resets it.
-- 
Your team Widelands Developers is requested to review the proposed merge of lp:~widelands-dev/widelands/bug-1773688-ui-starting-condition into lp:widelands.


Follow ups