widelands-dev team mailing list archive
-
widelands-dev team
-
Mailing list archive
-
Message #14037
Re: [Merge] lp:~widelands-dev/widelands/mines-worldsavior into lp:widelands
I have some proposals to fix the issues discovered.
see my latest post in
https://wl.widelands.org/forum/topic/4232/?page=8#post-25429
in short the mine programs should look like
programs = {
work = {
-- TRANSLATORS: Completed/Skipped/Did not start mining coal because ...
descname = _"mining coal",
actions = {
"sleep=40000",
"return=skipped unless economy needs coal",
"consume=smoked_fish,smoked_meat:2 atlanteans_bread:2",
"animate=working 60000",
"call=mine_produce",
"call=mine_produce",
"call=mine_produce",
"call=mine_produce",
"call=mine_produce",
"call=mine_produce",
"call=mine_produce",
}
},
mine_produce = {
-- TRANSLATORS: Completed/Skipped/Did not start mining coal because ...
descname = _"mining and producing",
actions = {
"sleep=1000",
"mine=coal 4 100 5 2",
"produce=coal",
},
},
Additionally the penalty for totally depleted fields should be removed in
https://bazaar.launchpad.net/~widelands-dev/widelands/trunk/view/head:/src/logic/map_objects/tribes/production_program.cc#L1214
last but not least statistics have to be fixed and the production return_string should be defined at the end of the complete "work programm" at least for the mines.
--
https://code.launchpad.net/~widelands-dev/widelands/mines-worldsavior/+merge/350716
Your team Widelands Developers is subscribed to branch lp:~widelands-dev/widelands/mines-worldsavior.
References