widelands-dev team mailing list archive
-
widelands-dev team
-
Mailing list archive
-
Message #14130
Re: [Merge] lp:~widelands-dev/widelands/lenient_allowed_buildings into lp:widelands
Review: Approve code
I haven't tested it, but the code looks okay.
One could consider displaying an in-game message instead/additionally to the console output. The console is probably overlooked by players, but a change in the building definitions could lead to broken scenario save games. Personally I don't think that this is important, though, if such a case happens loading will probably break in other steps as well.
--
https://code.launchpad.net/~widelands-dev/widelands/lenient_allowed_buildings/+merge/351749
Your team Widelands Developers is subscribed to branch lp:~widelands-dev/widelands/lenient_allowed_buildings.
References