widelands-dev team mailing list archive

[GunChleoc <fios@xxxxxxxxxxxxxxxxxxx>]

GunChleoc has proposed merging lp:~widelands-dev/widelands/bug-1791605-on-failure-fail into lp:widelands.

Commit message:
Remove test logging output from production_program.cc

Requested reviews:
  Widelands Developers (widelands-dev)
Related bugs:
  Bug #1791605 in widelands: "Warnings for "on failure fail" while loading tribes"
  https://bugs.launchpad.net/widelands/+bug/1791605

For more details, see:
https://code.launchpad.net/~widelands-dev/widelands/bug-1791605-on-failure-fail/+merge/356654
-- 
Your team Widelands Developers is requested to review the proposed merge of lp:~widelands-dev/widelands/bug-1791605-on-failure-fail into lp:widelands.

=== modified file 'src/logic/map_objects/tribes/production_program.cc'
--- src/logic/map_objects/tribes/production_program.cc	2018-09-10 12:32:56 +0000
+++ src/logic/map_objects/tribes/production_program.cc	2018-10-12 10:31:38 +0000
@@ -583,7 +583,6 @@
 		while (!reached_end) {
 			skip(parameters);
 			match_force_skip(parameters, "on");
-			log("found \"on \": parameters = \"%s\"\n", parameters);
 
 			ProgramResult result_to_set_method_for;
 			if (match_force_skip(parameters, "failure")) {
@@ -616,9 +615,6 @@
 				                    "{\"fail\"|\"complete\"|\"skip\"|\"repeat\"}", parameters);
 			handling_methods_[result_to_set_method_for - 1] = handling_method;
 			reached_end = !*parameters;
-			log("read handling method for result %u: %u, parameters = \"%s\", "
-			    "reached_end = %u\n",
-			    result_to_set_method_for, handling_method, parameters, reached_end);
 		}
 	} catch (const WException& e) {
 		throw GameDataError("call: %s", e.what());