← Back to team overview

widelands-dev team mailing list archive

Thread
Date

Re: [Merge] lp:~widelands-dev/widelands/terrain_affinity_as_int into lp:widelands

To: mp+358299@xxxxxxxxxxxxxxxxxx
From: Arty <diego.scheide@xxxxxx>
Date: Fri, 23 Nov 2018 10:04:38 -0000
In-reply-to: <154140543704.14661.4227248472558481021.launchpad@ackee.canonical.com>
Reply-to: mp+358299@xxxxxxxxxxxxxxxxxx
Sender: bounces@xxxxxxxxxxxxx

Review: Approve

Looks good now.

The comment with the assciativity is kinda obsolete now though.

And using int64_t wasn't really necessary now that you use the weights linearly.
-- 
https://code.launchpad.net/~widelands-dev/widelands/terrain_affinity_as_int/+merge/358299
Your team Widelands Developers is subscribed to branch lp:~widelands-dev/widelands/terrain_affinity_as_int.

References

[Merge] lp:~widelands-dev/widelands/terrain_affinity_as_int into lp:widelands
From: GunChleoc, 2018-11-05