← Back to team overview

widelands-dev team mailing list archive

Re: [Merge] lp:~widelands-dev/widelands/bug-1815277-persistence-memory-leak into lp:widelands


I was able to reproduce the memory leak of the bug report but I wasn't able to observe a change by this branch. Both times I loaded the same autosave single player game of Autocrat and got the same leak-message (except for the memory addresses). Should something change in the output?

I am also unsure whether your change really changes anything. As far as I know, a reference is basically another way to write a pointer, so no memory release is done by your code. But maybe I am wrong about this.

>From the call stack and some digging through the eris code (that I don't really understand) it seems to me as if the leak is / might be in the u_closure() function deep within the eris code. Do we fix third-party leaks or do we just ignore them?
Your team Widelands Developers is requested to review the proposed merge of lp:~widelands-dev/widelands/bug-1815277-persistence-memory-leak into lp:widelands.