widelands-dev team mailing list archive

Thread
Date

Re: [Merge] lp:~widelands-dev/widelands/cleanup-soundhandler into lp:widelands

To: mp+365001@xxxxxxxxxxxxxxxxxx
From: GunChleoc <fios@xxxxxxxxxxxxxxxxxxx>
Date: Mon, 08 Apr 2019 06:40:11 -0000
In-reply-to: <155335023133.3417.16508699794985949552.launchpad@ackee.canonical.com>
Reply-to: mp+365001@xxxxxxxxxxxxxxxxxx
Sender: bounces@xxxxxxxxxxxxx

That message should come up every time that the song finishes playing and starts again.

Yep, definitely a big code review. Probably best do it with a diff program like Meld and add your remarks as NOCOM comments to the code. I'll merge trunk now to make the diff smaller.
-- 
https://code.launchpad.net/~widelands-dev/widelands/cleanup-soundhandler/+merge/365001
Your team Widelands Developers is requested to review the proposed merge of lp:~widelands-dev/widelands/cleanup-soundhandler into lp:widelands.

References

[Merge] lp:~widelands-dev/widelands/cleanup-soundhandler into lp:widelands
From: GunChleoc, 2019-03-23