widelands-dev team mailing list archive

[hessenfarmer <stephan-lutz@xxxxxx>]

Found at least one questionable change in ai code see inline.
needs intensive testing of programs especially for the mines

Diff comments:

> 
> === modified file 'src/ai/defaultai.cc'
> --- src/ai/defaultai.cc	2019-03-24 13:13:34 +0000
> +++ src/ai/defaultai.cc	2019-04-09 17:16:30 +0000
> @@ -5458,10 +5455,9 @@
>  			inputs[14] = (bo.current_stats - 50) / 10;
>  			inputs[15] = management_data.get_military_number_at(123) / 10;
>  			inputs[16] = 0;
> -			inputs[17] = (inputs_on_stock) ? 0 : -2;
> +			inputs[17] = (inputs_on_stock) ? 0 : -4;
>  			inputs[18] = (suppliers_exist) ? 0 : -3;
> -			;
> -			inputs[17] = (inputs_on_stock) ? 0 : -4;
> +			// Nothing on inputs[19]

I am pretty certain that this had been a typo writing [17] instead of [19]

>  			inputs[20] =
>  			   (mines_per_type[bo.mines].in_construction + mines_per_type[bo.mines].finished == 1) ?
>  			      3 :


-- 
https://code.launchpad.net/~widelands-dev/widelands/bug-1823612-llvm8-build-errors/+merge/365644
Your team Widelands Developers is subscribed to branch lp:~widelands-dev/widelands/bug-1823612-llvm8-build-errors.