← Back to team overview

widelands-dev team mailing list archive

Re: [Merge] lp:~widelands-dev/widelands/per-level-soldier-anims into lp:widelands

 

I'm not sure that this operator is correct:

        bool operator<(const SoldierLevelRange& other) const {
                return max_health < other.min_health &&
                       max_attack < other.min_attack &&
                       max_defense < other.min_defense &&
                       max_evade < other.min_evade;
        }

For example, what if the range is identical except for health?
-- 
https://code.launchpad.net/~widelands-dev/widelands/per-level-soldier-anims/+merge/354929
Your team Widelands Developers is requested to review the proposed merge of lp:~widelands-dev/widelands/per-level-soldier-anims into lp:widelands.


References