widelands-dev team mailing list archive

[GunChleoc <fios@xxxxxxxxxxxxxxxxxxx>]

1 nit, not tested yet.

Diff comments:

> === modified file 'src/logic/map_objects/tribes/production_program.cc'
> --- src/logic/map_objects/tribes/production_program.cc	2019-04-24 06:01:37 +0000
> +++ src/logic/map_objects/tribes/production_program.cc	2019-04-27 13:34:24 +0000
> @@ -1415,6 +1415,7 @@
>  		throw wexception("Fail training soldier!!");
>  	}
>  	ps.molog("  Training done!\n");
> +	ps.set_production_result((boost::format(_("Completed %u")) % ps.top_state().program->descname()).str());

You need to use %s and call c_str() on the descname to turn it into a const char. %u is for unsigned integers.

>  
>  	upcast(TrainingSite, ts, &ps);
>  	ts->training_successful(attribute, level);


-- 
https://code.launchpad.net/~widelands-dev/widelands/bugfix-buildings-tooltips/+merge/366607
Your team Widelands Developers is requested to review the proposed merge of lp:~widelands-dev/widelands/bugfix-buildings-tooltips into lp:widelands.