← Back to team overview

widelands-dev team mailing list archive

Re: [Merge] lp:~widelands-dev/widelands/refactor_gameclient into lp:widelands

 

You could also do the game tips like this:

    const std::string tribename = get_players_tribe();
    assert(Widelands::tribe_exists(tribename));
    std::unique_ptr<GameTips> tips(new GameTips(*loader, {"general_game", "multiplayer", tribename}));


As to the ASan crash, I suspect that there is a problem with the lifetime of an object caused by the pulling out of stuff into separate functions.
-- 
https://code.launchpad.net/~widelands-dev/widelands/refactor_gameclient/+merge/366743
Your team Widelands Developers is requested to review the proposed merge of lp:~widelands-dev/widelands/refactor_gameclient into lp:widelands.


References