widelands-dev team mailing list archive

Thread
Date

Re: [Merge] lp:~widelands-dev/widelands/AI-fixes into lp:widelands

To: hessenfarmer <stephan-lutz@xxxxxx>
From: TiborB <tiborb95@xxxxxxxxx>
Date: Sun, 12 May 2019 06:32:51 -0000
In-reply-to: <155760926302.30401.7429660006787150434.launchpad@ackee.canonical.com>
Reply-to: mp+367309@xxxxxxxxxxxxxxxxxx
Sender: bounces@xxxxxxxxxxxxx

Review: Approve

>From AI code point of view - The changes can be OK, it is hard to say just looking at the code. I presume that you made sure the magic numbers does not repeat - dont forget they are used also in other AI files...
I will do some training once it is approved and merged.
I did not review changes to LUA code..
So for my part it is OK
-- 
https://code.launchpad.net/~widelands-dev/widelands/AI-fixes/+merge/367309
Your team Widelands Developers is subscribed to branch lp:~widelands-dev/widelands/AI-fixes.

References

[Merge] lp:~widelands-dev/widelands/AI-fixes into lp:widelands
From: hessenfarmer, 2019-05-11