widelands-dev team mailing list archive

[Toni Förster <toni.foerster@xxxxxxxxx>]

Toni Förster has proposed merging lp:~widelands-dev/widelands/bug-1830776-password-field-captures-input into lp:widelands.

Commit message:
don't force focus on password field

Requested reviews:
  Widelands Developers (widelands-dev)
Related bugs:
  Bug #1830776 in widelands: "Input is captured in password field in online loginbox"
  https://bugs.launchpad.net/widelands/+bug/1830776

For more details, see:
https://code.launchpad.net/~widelands-dev/widelands/bug-1830776-password-field-captures-input/+merge/368063
-- 
Your team Widelands Developers is requested to review the proposed merge of lp:~widelands-dev/widelands/bug-1830776-password-field-captures-input into lp:widelands.

=== modified file 'src/wui/login_box.cc'
--- src/wui/login_box.cc	2019-05-26 01:59:32 +0000
+++ src/wui/login_box.cc	2019-05-29 12:51:06 +0000
@@ -144,6 +144,7 @@
 	} else {
 		ta_password->set_style(g_gr->styles().font_style(UI::FontStyle::kLabel));
 		eb_password->set_can_focus(true);
+		eb_password->focus();
 	}
 }
 
@@ -168,7 +169,6 @@
 	if (eb_password->text().empty() && cb_register->get_state()) {
 		eb_password->set_tooltip(_("Please enter your password!"));
 		loginbtn->set_enabled(false);
-		eb_password->focus();
 	}
 
 	Section& s = g_options.pull_section("global");