widelands-dev team mailing list archive

[Notabilis <notabilis27@xxxxxx>]

Notabilis has proposed merging lp:~widelands-dev/widelands/net-more-resolve-logging into lp:widelands.

Commit message:
More log output if trying to resolve network addresses

Requested reviews:
  Widelands Developers (widelands-dev)

For more details, see:
https://code.launchpad.net/~widelands-dev/widelands/net-more-resolve-logging/+merge/368955

Some more log output to help debug network problems.
-- 
Your team Widelands Developers is requested to review the proposed merge of lp:~widelands-dev/widelands/net-more-resolve-logging into lp:widelands.

=== modified file 'src/network/network.cc'
--- src/network/network.cc	2019-02-23 11:00:49 +0000
+++ src/network/network.cc	2019-06-18 06:13:12 +0000
@@ -38,14 +38,19 @@
 		boost::asio::ip::tcp::resolver::iterator iter = resolver.resolve(query);
 		if (iter == boost::asio::ip::tcp::resolver::iterator()) {
 			// Resolution failed
+			log("Could not resolve network name '%s:%u' to %s-address\n", hostname.c_str(),
+				port, ((protocol == boost::asio::ip::tcp::v4()) ? "IPv4" : "IPv6"));
 			return false;
 		}
 		addr->ip = iter->endpoint().address();
 		addr->port = port;
+		log("Resolved network name '%s:%u' to %s\n",
+			hostname.c_str(), port, addr->ip.to_string().c_str());
 		return true;
 	} catch (const boost::system::system_error& ec) {
 		// Resolution failed
-		log("Could not resolve network name: %s\n", ec.what());
+		log("Could not resolve network name '%s:%u' to %s-address: %s\n", hostname.c_str(),
+			port, ((protocol == boost::asio::ip::tcp::v4()) ? "IPv4" : "IPv6"), ec.what());
 		return false;
 	}
 }