← Back to team overview

widelands-dev team mailing list archive

Thread
Date

Re: [Merge] lp:~widelands-dev/widelands/bug-1842396-no-tribe into lp:widelands

To: mp+372281@xxxxxxxxxxxxxxxxxx
From: GunChleoc <fios@xxxxxxxxxxxxxxxxxxx>
Date: Thu, 05 Sep 2019 05:57:08 -0000
In-reply-to: <156761726164.10410.8969800060725285016.launchpad@ackee.canonical.com>
Reply-to: mp+372281@xxxxxxxxxxxxxxxxxx
Sender: bounces@xxxxxxxxxxxxx

Review: Approve

Thanks for fixing :)

Wouldn't it be better to use if(Widelands::tribe_exists(tribename)) rather than triggering the exception?
-- 
https://code.launchpad.net/~widelands-dev/widelands/bug-1842396-no-tribe/+merge/372281
Your team Widelands Developers is subscribed to branch lp:~widelands-dev/widelands/bug-1842396-no-tribe.

References

[Merge] lp:~widelands-dev/widelands/bug-1842396-no-tribe into lp:widelands
From: Notabilis, 2019-09-04