wordpress-charmers team mailing list archive

Thread
Date

Re: [Merge] ~mthaddon/charm-k8s-wordpress/+git/wordpress-k8s-image-builder:build-focal into ~wordpress-charmers/charm-k8s-wordpress/+git/wordpress-k8s-image-builder:master

To: Tom Haddon <tom.haddon@xxxxxxxxxxxxx>
From: Barry Price <barry.price@xxxxxxxxxxxxx>
Date: Tue, 21 Jan 2020 06:31:09 -0000
In-reply-to: <157954564256.17656.17255740695692023583.launchpad@ackee.canonical.com>
Reply-to: mp+377837@xxxxxxxxxxxxxxxxxx
Sender: bounces@xxxxxxxxxxxxx

Review: Needs Fixing

Couple of things:

1. Let's tag with series, e.g. wordpress:bionic-latest and wordpress:focal-latest
2. Making fetch/build separate steps without a dependency means we can (accidentally) build an image without the themes/plugins included. I don't think we want to block this, but warning the user if e.g. files/themes/ and files/plugins/ dirs are empty might be good.
3. These are going to clash (one of us will need to fix, fine if you think that's me!):

https://code.launchpad.net/~barryprice/charm-k8s-wordpress/+git/wordpress-k8s-image-builder/+merge/377851
-- 
https://code.launchpad.net/~mthaddon/charm-k8s-wordpress/+git/wordpress-k8s-image-builder/+merge/377837
Your team Wordpress Charmers is subscribed to branch ~wordpress-charmers/charm-k8s-wordpress/+git/wordpress-k8s-image-builder:master.

References

[Merge] ~mthaddon/charm-k8s-wordpress/+git/wordpress-k8s-image-builder:build-focal into ~wordpress-charmers/charm-k8s-wordpress/+git/wordpress-k8s-image-builder:master
From: Tom Haddon, 2020-01-20