wordpress-charmers team mailing list archive

[Tom Haddon <tom.haddon@xxxxxxxxxxxxx>]

Review: Approve

Approved with one comment about adding a comment

Diff comments:

> diff --git a/Dockerfile b/Dockerfile
> index a6bed91..f667d10 100644
> --- a/Dockerfile
> +++ b/Dockerfile
> @@ -1,7 +1,11 @@
>  FROM ubuntu:bionic
>  
> -ARG http_proxy
> -ARG https_proxy
> +LABEL maintainer="wordpress-charmers@xxxxxxxxxxxxxxxxxxx"
> +
> +ARG HTTPS_PROXY

Might be worth a comment as to what this is used for as it's not referenced directly anywhere else in the Dockerfile

> +ARG BUILD_DATE
> +
> +LABEL org.label-schema.build-date=$BUILD_DATE
>  
>  # Avoid interactive prompts
>  RUN echo 'debconf debconf/frontend select Noninteractive' | debconf-set-selections


-- 
https://code.launchpad.net/~barryprice/charm-k8s-wordpress/+git/wordpress-k8s-image-builder/+merge/377851
Your team Wordpress Charmers is subscribed to branch ~wordpress-charmers/charm-k8s-wordpress/+git/wordpress-k8s-image-builder:master.