yade-dev team mailing list archive

[Václav Šmilauer <eudoxos@xxxxxxxx>]

Sega, really nice work!

I would ask you to add some documentation to the sources, though.
Generally, we would like to have all classes some documentation, even if
only few lines. The commit message could be a good documentation for
STLImporter. At some place, the "big picture" of why classes like
Interacting{Facet,Edge,Vetex} exist could be given - the wiki, or
perhaps in a sample FileGenerator..

For the collider, you should at least reference the algorithm that is
used (I know what quicksort is, but in what way it is used on bodies
here and so on). Do you plan to adapt the collider to distant
interactions as well? It means just not deleting the interaction and not
setting isReal to false, if the interaction already has already been
real in previous iteration.

If you put FIXME to your code, what follows should be in english. If
something goes wrong during execution, I may look at the code and will
just see FIXME without knowing what it says.

In python scripts (Sconscript), please use tabs consistently, since
mixing spaces with tabs will do havoc for us - I have tabsize of 3
spaces, so your 4 spaces will be after my tab but before your tab etc. I
can fix that in the next commit, no problem.

You may prefer related classes to be put into single source file (using
YADE_PLUGIN("InteractingFacet","InteractngEdge","InteractingVertex"),
for example), but that is matter of tase; for me, sources are more
navigable that way.

Thanks for your contribution.

Vaclav

_______________________________________________
yade-dev mailing list
yade-dev@xxxxxxxxxxxxxxxx
https://lists.berlios.de/mailman/listinfo/yade-dev