yade-dev team mailing list archive

[sega <dorofeenko@xxxxxxxxx>]

Sorry for errors. I will fix them in the next svn...

> 1. First and foremost, you HAVE TO document new classes you create, so
> that other people can use them (filtering engines look very useful,
> btw). (it was the same with facets, which are great, please bear this in
> mind)
I agree. The documentation should be created more accurately as YADE is _very_ badly documented (though it does not prevent it to use to me :), but strongly prevented to master...). In the future I will document more accurately (unfortunately, now I have no time for this purpose at all).

> 
> 2. Does it seem right to put filtering engines into MetBody::engines as
> they are used only for scene rendering. 
and for data probing  may be...

> Perhaps adding filter to 
> OpenGLRenderingEngine would make more sense? 
Perhaps... But I don't know what is OpenGLRenderingEngine and how it work.
(and I haven't time to know it without documentation ). 

> Clipping planes and such 
> could be moved to those pre-rendering engines. 
Yes, I think about it too.

> In such way, those 
> engines would not be run if you don't need the rendering - like if you
> run without GL or if drawing is slower than simulation; they would be
> run only right before drawing. 
And now it is. Those engines would be run if they is activated from GUI.

> 
> > Added: trunk/core/FiltrEngine.cpp
> >   
> 3. I moved it to common, which seems like more appropriate space
> (comment in the commit log). (FilterEngine? Filtr looks like a typo...)
Ok. I will fix it.
Question: how it is possible to make a legend, for example, with velocity colour scale?

> 
> 5. Would you mind running compilation before you commit? You were
> missing one logger 
Hm.. I haven't errors with it.... 

> and had FiltrationalEngine.hpp instead of 
> FiltrEngine.hpp in the player and other errors.
Sorry.

> 6. Can you please decrease vertical size of the player window and put
> filtration button elsewhere (decrease the message area, get rid of
> baseName boxes etc) or something? It doesn't fit on the screen with
> 1024x768!
I have not understood a problem. At me the sizes of a window change. 
The sizes of its boxes also change...


-- 
Best regards, Sergei D.
_______________________________________________
yade-dev mailing list
yade-dev@xxxxxxxxxxxxxxxx
https://lists.berlios.de/mailman/listinfo/yade-dev