yade-dev team mailing list archive
-
yade-dev team
-
Mailing list archive
-
Message #03344
Re: WM3 -> Eigen migration
> It seems, I have done it. But I have a problem with static members.
> Could you not check it in r30?
>
> Do we need templates for Vector2?
Yes we do, Vector2i is used in the code. I am not sure if everything
will work without Matrix3r and Quaternionr being templates, we will have
to adjust serialization a little, but it shoudl be doable.
1. Please have a look at what is needed from the Wm3::Math<ScalarType>
class, I remember only seeing Mathr::PI in the code. (no need for
template for here) and wrap that as well, class with a few static
memebers.
2. Have a look at lib/base/yadeWm3Extra, it defines a few stand-alone
functions; grep yade to see which ones are used and copy those to your
header as well. (componentMaxVector and such, IIRC)
I just removed all mentions of wm3 from yade, and wm3 is only included
from lib/base/Math.hpp. There is a switch and it will include different
headers if eigen is in used (not yet activated).
I also removed wrapper for everything we don't need (such as Vector4),
to make sure we really don't need it. To summarize, we use
Vector3r, Vector3i
Vector2r, Vector2i
Matrix3r
Quaterionr
Mathr
that's it.
Good job, Anton!
Cheers, Vaclav
Follow ups
References
-
WM3 -> Eigen migration
From: Anton Gladky, 2010-01-21
-
Re: WM3 -> Eigen migration
From: Václav Šmilauer, 2010-02-02
-
Re: WM3 -> Eigen migration
From: Anton Gladky, 2010-02-02
-
Re: WM3 -> Eigen migration
From: Václav Šmilauer, 2010-02-02
-
Re: WM3 -> Eigen migration
From: Anton Gladky, 2010-02-02
-
Re: WM3 -> Eigen migration
From: Anton Gladky, 2010-02-04
-
Re: WM3 -> Eigen migration
From: Anton Gladky, 2010-02-05
-
Re: WM3 -> Eigen migration
From: Anton Gladky, 2010-02-09
-
Re: WM3 -> Eigen migration
From: Václav Šmilauer, 2010-02-09
-
Re: WM3 -> Eigen migration
From: Anton Gladky, 2010-02-09