yade-dev team mailing list archive

[Anton Gladky <gladky.anton@xxxxxxxxx>]

Thanks, Vaclav, for comments:

It seems, I have done it. I just have some problems with:
unitVectorsAngle, EPSILON and MAX_REAL

They are commented now. Could you not check it?

______________________________

Anton Gladkyy


2010/2/9 Václav Šmilauer <eudoxos@xxxxxxxx>

>
> > It seems, I have done it. But I have a problem with static members.
> > Could you not check it in r30?
> >
> > Do we need templates for Vector2?
> Yes we do, Vector2i is used in the code. I am not sure if everything
> will work without Matrix3r and Quaternionr being templates, we will have
> to adjust serialization a little, but it shoudl be doable.
>
> 1. Please have a look at what is needed from the Wm3::Math<ScalarType>
> class, I remember only seeing Mathr::PI in the code. (no need for
> template for here) and wrap that as well, class with a few static
> memebers.
>
> 2. Have a look at lib/base/yadeWm3Extra, it defines a few stand-alone
> functions; grep yade to see which ones are used and copy those to your
> header as well. (componentMaxVector and such, IIRC)
>
> I just removed all mentions of wm3 from yade, and wm3 is only included
> from lib/base/Math.hpp. There is a switch and it will include different
> headers if eigen is in used (not yet activated).
>
> I also removed wrapper for everything we don't need (such as Vector4),
> to make sure we really don't need it. To summarize, we use
>
> Vector3r, Vector3i
> Vector2r, Vector2i
> Matrix3r
> Quaterionr
> Mathr
>
> that's it.
>
> Good job, Anton!
>
> Cheers, Vaclav
>
>
>
>
>
>
> _______________________________________________
> Mailing list: https://launchpad.net/~yade-dev<https://launchpad.net/%7Eyade-dev>
> Post to     : yade-dev@xxxxxxxxxxxxxxxxxxx
> Unsubscribe : https://launchpad.net/~yade-dev<https://launchpad.net/%7Eyade-dev>
> More help   : https://help.launchpad.net/ListHelp
>