yade-dev team mailing list archive
-
yade-dev team
-
Mailing list archive
-
Message #03739
Re: Capillary files
I was also thinking renaming, good time for that.
CapillaryCohesiveLaw should be renamed CapillaryLaw; since there is no
cohesion at all in this law ("cohesion" is just one way to interpret
capillary effects at the macroscopic level).
And functors like "Simple...bla...Water" can be renamed to be in line
with other functors names.
Ok for that?
Bruno
Bruno Chareyre a écrit :
Hi Luc,
I'm cleaning a little theses days, a few questions and remarks :
1- What is the use of having capillaryRecorder +
capillaryStressRecorder + contactStressRecorder? Aren't they doing
more or less the same thing? Try to pick one (in TTWater, only one is
used right?) and we remove the others.
2- Be carefull with end of files, it seems you tend to remove the last
empty line, which give compile warnings for everybody.
3- Also try to be consistent with indentation, we use tabs, not
spaces; and please remove useless comments and/or empty lines when you
see them.
Thanks.
Bruno
--
_______________
Bruno Chareyre
Associate Professor
Grenoble INP
Lab. 3SR
BP 53 - 38041, Grenoble cedex 9 - France
Tél : 33 4 56 52 86 21
Fax : 33 4 76 82 70 43
________________
References