yade-dev team mailing list archive

[Janek Kozicki <janek_listy@xxxxx>]

Anton Gladky said:     (by the date of Mon, 12 Jul 2010 12:38:04 +0200)

> >
> > use bzr blame to find who wrote this. This code is crazy wrong.
> >
> 
> Can you propose something better?

why it must return a pointer? couldn't be just like that:

Quaternionr Quaternionr_fromAxisAngle(const Vector3r& axis, const Real angle){ return Quaternionr(AngleAxisr(angle,axis)); }
Quaternionr Quaternionr_fromAngleAxis(const Real angle, const Vector3r& axis){ return Quaternionr(AngleAxisr(angle,axis)); }

but.. umm this code isn't use anywhere, or I am blind?

trunk$ grep Quaternionr_fromAxisAngle ./* -Rl
./py/mathWrap/miniEigen.cpp

trunk$ grep Quaternionr_fromAngleAxis ./* -Rl
./py/mathWrap/miniEigen.cpp

oh, I'm sorry... it's used for a python wrapper line 263


.def("__init__",bp::make_constructor(&Quaternionr_fromAxisAngle,bp::default_call_policies(),(bp::arg("axis"),bp::arg("angle"))))
.def("__init__",bp::make_constructor(&Quaternionr_fromAngleAxis,bp::default_call_policies(),(bp::arg("angle"),bp::arg("axis"))))


why python needs this to be a pointer?

-- 
Janek Kozicki                               http://janek.kozicki.pl/  |