← Back to team overview

yade-dev team mailing list archive

Re: [Bug 603227] [NEW] Rotation of facet_sphere_scgeom?

 

Anton, Sergei, it seems you are the ones maintaining and/or using facet-sphere code. Are you really aware of this last addition in the code? I've seen not much reaction. I've another uncommited diff (precompute), result of some search-replace after changes in ScGeom (in the case of facet functor, it is in fact more "nothing found"->"put what should be there"). This alone could explain "hanging" particles and other opened bugs (e.g. the "scaleDispT" one). The previous code was (I think) assuming fixed facets, which is not exactly relevant for rotating cylinder. The problem is I still don't know how to reproduce hanging particles and I can only guess what sort of laws are used. I don't see myself fixing bugs I don't know in some code I don't fully understand...

Cheers.

Bruno




On 08/07/10 22:04, Bruno Chareyre wrote:
On 08/07/10 21:54, Sergei D. wrote:
08.07.2010 20:08, Chareyre:
Public bug reported:

Implementing precomputed ScGeom in Ig2_Facet_Sphere_ScGeom, I realized that previousNormal is not updated and not used at all in this one. It might well be linked with other bugs.

Ig2_Facet_Sphere_ScGeom.cpp:
107    if(isNew) { scm->prevNormal=normal;}
108    else scm->prevNormal=scm->normal;

I just added it in 2336. ;-)
I didn't run any test though, and it may have no effect at all.
For sure it should be investigated.

Bruno


_______________________________________________
Mailing list: https://launchpad.net/~yade-dev
Post to     : yade-dev@xxxxxxxxxxxxxxxxxxx
Unsubscribe : https://launchpad.net/~yade-dev
More help   : https://help.launchpad.net/ListHelp





Follow ups

References