yade-dev team mailing list archive

[Bruno Chareyre <bruno.chareyre@xxxxxxxxxxx>]

> 1. I don't think size should be settable to set lengths of hSize. If
> you really need something like that, you're probably smart enough to
> change hSize directly. setBox was meant as name that explicitly sets
> axis-aligned box.
Size=... is just the interace for setting hSize with a vector. 
I don't see how setBox can help. Is somebody fool enough to (1) start by
defining a non-aligned cell, then (2) make it aligned again? I don't
hink so. For an aligned cell, he will only changes sizes: cell.size=...
and it will be aligned. I recall this can only be done at

Anyway, we can have both setBox and size=... if setBox is also usefull.
I'll add "size=..."
> 2. why removing refHSize0?
Because it is uselss. It's used nowhere in c++ and nowhere in scripts.
If somebody wants trsf^-1*H one day (why would he need that btw?), he
can compute it like trsf.inverse()*hSize.
> 3. Setting refHSize is right as it was, I think. It is what I would
> expect. Do you have a real problem with that? It is used just for the
> displacement scaling.
Perhaps I don't understand what it is supposed to do, but please see the
(3rd) paragraph on per-step loading here
https://www.yade-dem.org/doc/2703/formulation.html#periodic-boundary-conditions.

If you do this: {setRefSe3; run; trsf=Id; run;}, your particles
displacements and cell deformation will (I think) not be compatible.
Then you will have to change trsf at the end because cell ref and bodies
ref are not defined at the same iteration.
With last change, the interval for scaled displacement is independant of
what you do with trsf. Cell deformation and bodies disps are always
consistent. The 3rd paragraph can be just removed.
 
> 4. The backwards-compatible code... Since refSize can be set as it was
> before, I think we are sufficiently backwards-compatible (at least the
> triaxial script from dresden, for instance, worked just fine, and gave
> the right warnings about what to update)
Yes, I didn't plan to add more things for compat, I actually removed
some (they are back now).  

> We obviously suck at collaboration and I hope that NewtonIntegrator
> and Cell are the only parts of the code we will share in the future;
> otherwise I will have to fork ;-)
Yeah, we can progress on that part. :-)
I thought the main ideas were clear after last mails, then anticipated
the commit too much. The point is the whole concept of reference size or
reference state can be removed from cell. That's why I was a bit
surprised to see it introduced again in hSize0, for instance. We could
keep only refSize for compat, then move refHsize to OGL, so we could
finally consider PBCs (cell and engines) "reference-free" (backward
excepted).
Removing things was only a way (even if a bit extreme ;-) ) to show that
the removed attributes were not needed.
Could you say why you need them?

Cheers.

Bruno

> Cheers, v.
>
> _______________________________________________
> Mailing list: https://launchpad.net/~yade-dev
> Post to     : yade-dev@xxxxxxxxxxxxxxxxxxx
> Unsubscribe : https://launchpad.net/~yade-dev
> More help   : https://help.launchpad.net/ListHelp
>


-- 
_______________
Bruno Chareyre
Associate Professor
ENSE³ - Grenoble INP
Lab. 3SR
BP 53 - 38041, Grenoble cedex 9 - France
Tél : +33 4 56 52 86 21
Fax : +33 4 76 82 70 43
________________