yade-dev team mailing list archive

[Jérôme Duriez <jerome.duriez@xxxxxxxxxxxxxxx>]

Hi Anton,

In this commit you removed apparently the lines 730 to 734 of older 
version of VTKRecorder.cpp file.

It is about visualizing interactions that lost their cohesive feature, 
in JCFpm simulations. These lines of code actually concern the "broken" 
interactions that broke since previous execution of VTKRecorder, so that 
only "newly" (between 2 successive snapshots) broken interactions can be 
directly vizualized, instead of the whole quantity of broken 
interactions (which can also be vizualized).

I introduced this particuliar feature. But concerning the on-line code, 
it was only in a commented version, since other users may use Paraview 
better than I do, and achieve the same vizualisation with the first set 
of VTK files with all broken interactions. In this case, a new set of 
VTK files, as those I'm saving on my PC, is useless... I hoped commented 
lines do not hurt.

So, my question is :

- did you think commented lines finally hurt, and that's why you removed 
them ? (and in this case, there are other commented lines about this 
topic that could be removed)
- or, do they finally not hurt, and I reput them on-line, (replacing the 
use of SetInput() by SetInputData() #ifdef YADE_VTK6, if you confirm me 
this was indeed the main idea of your commit)
(- or, but I would be surprized, is there an interest to let always 
create these two sets of VTK files about broken interactions, as I'm 
doing on my PC. And I would uncomment all the corresponding lines)


However I wrote many lines trying to be clear, it is in fact not a big 
deal in any case...

Jerome




Le 30/10/2013 15:24, noreply@xxxxxxxxxxxxx a écrit :
> ------------------------------------------------------------
> revno: 3735
> committer: Anton Gladky <gladky.anton@xxxxxxxxx>
> timestamp: Wed 2013-10-30 08:54:30 +0100
> message:
>    Provide VTK6-support.
> modified:
>    CMakeLists.txt
>    pkg/dem/VTKRecorder.cpp
>
>
> --
> lp:yade
> https://code.launchpad.net/~yade-pkg/yade/git-trunk
>
> Your team Yade developers is subscribed to branch lp:yade.
> To unsubscribe from this branch go to https://code.launchpad.net/~yade-pkg/yade/git-trunk/+edit-subscription
>
>
> _______________________________________________
> Mailing list: https://launchpad.net/~yade-dev
> Post to     : yade-dev@xxxxxxxxxxxxxxxxxxx
> Unsubscribe : https://launchpad.net/~yade-dev
> More help   : https://help.launchpad.net/ListHelp

--
Jérôme Duriez
Post-Doctorant UJF
Laboratoire 3SR
Bureau E139 - 04.56.52.86.30