yade-dev team mailing list archive

[Klaus Thoeni <klaus.thoeni@xxxxxxxxx>]

Sorry for late reply, but here my thoughts. I think a separation at material 
level would be better, i.e. FrictMat inherits ViscElastMat which inherits 
something like  ViscElCapillarMat. I think it would make sense because not all 
visco-elastic materials have capillar forces. What do you think?

In the case of CapillaryPhys none of the parameters is stored in FrictMat. 
There seams to be a bit of inconsistency. Same with kn and kt. Should the 
material have these parameters or the Ip2 functor? IMO, stiffness is related to 
a specific contact and should therefore be in the Ip2. 

I think we need to make a decision. I think we should keep it one way and not 
mix it.  

Klaus

On Tuesday 28 January 2014 15:25:04 Bruno Chareyre wrote:
> On 28/01/14 14:10, Anton Gladky wrote:
> > That is true. I actually moved an implementations into
> > ViscoelasticCapillarPM [1], but parameters are still in the parent
> > class. Any suggestions how to improve it are very welcome.
> 
> If I don't miss something, it could be just like CapillaryPhys, which
> inherits from FrictPhys.
> The "cappilar" version of the contact law would read
> 
> Law2_ScGeom_ViscElPhys_Capillar::go(...) {
>     Law2_ScGeom_ViscElPhys_Basic::go(...);
>    // add capillary forces here
>    ...
> }
> 
> If not possible (*), you can extract code blocks from
> Law2_ScGeom_ViscElPhys_Basic::go and put them in separate functions that
> can be called in child classes.
> 
> Law2_ScGeom_ViscElPhys_Capillar::go(...) {
>     Law2_ScGeom_ViscElPhys_Basic::computeForceTorque(...,f);
>    // add capillary forces here
>    ...
> }
> 
> (*) one problem I anticipate is that Law2_ScGeom_ViscElPhys_Basic::go()
> could erase an interaction that is still alive wrt the capillary model.
> Hence the split of go() in different functions.
> 
> Bruno
> 
> _______________________________________________
> Mailing list: https://launchpad.net/~yade-dev
> Post to     : yade-dev@xxxxxxxxxxxxxxxxxxx
> Unsubscribe : https://launchpad.net/~yade-dev
> More help   : https://help.launchpad.net/ListHelp