yade-dev team mailing list archive

[Bruno Chareyre <bruno.chareyre@xxxxxxxxxxx>]

On 22/07/14 17:07, Anton Gladky wrote:
> 2014-07-22 16:36 GMT+02:00 Bruno Chareyre <bruno.chareyre@xxxxxxxxxxx>:
>> Quick question: do you know why you could remove some YADE_PLUGIN macro
>> without problems (in e.g. Box)?
>> Does it mean they could be removed everywhere??
> They should not be removed, but moved to any CPP-file with
> the corresponding header.  If you remove them, those "plugins"
> will not be accessible.

Ah, now I see that most YADE_PLUGIN are back in MatchMaker.cpp. I was
not expecting that.
Not really where I would look for them. Though I don't see an obvious
solution.
Why is GenericSphereContact in DomainLimiter.cpp instead?
Maybe a common.cpp?

Overall, I would not try too hard to eliminate the cpp's.
Implementation in hpp is not good practice, and this is not where we
gain compilation time (instead, it is likely to be slower if the same
thing is compiled many times).
Merging is what makes things faster.

Bruno