← Back to team overview

yade-dev team mailing list archive

Re: Removing some small .cpp-files

 

2014-07-22 19:10 GMT+02:00 Bruno Chareyre <bruno.chareyre@xxxxxxxxxxx>:
> Ah, now I see that most YADE_PLUGIN are back in MatchMaker.cpp. I was
> not expecting that.
> Not really where I would look for them. Though I don't see an obvious
> solution.
> Why is GenericSphereContact in DomainLimiter.cpp instead?
> Maybe a common.cpp?

Sorry, it was temporal solution, I will move all of those plugins
into a common.cpp.

> Overall, I would not try too hard to eliminate the cpp's.
> Implementation in hpp is not good practice, and this is not where we
> gain compilation time (instead, it is likely to be slower if the same
> thing is compiled many times).
> Merging is what makes things faster.

Agree, but I did not move a lot of code into .hpp. Mostly just
default constructors and destructors. Yes, there were some
functions, which are now in .hpp, se we can move them into a
common.cpp.

Anton


References