yade-dev team mailing list archive

[Anton Gladky <gladky.anton@xxxxxxxxx>]

Hi Bruno,

yes, ids are unique now for each body. So if we add some more of
them, the maximal id-number is increasing.

I think it is more clear and important for post-processing and post-analyze.
If you analyze particle history, for example. The previous implementation gave
no guarantee, that a particular body is unique.

The problem is, of course, that we do not have a number of active
bodies. I think we should add one more method, which should calculate
number of real bodies. A variable is also an option, but we should escape
race condition in this case.

Do you observe some problems with this commit?

Best regards

Anton


2014-09-15 11:20 GMT+02:00 Bruno Chareyre <bruno.chareyre@xxxxxxxxxxx>:
> Hi Anton,
> I'm a bit late on that one but... does it mean that the size ob O.bodies is
> increasing forever when bodies are deleted and added?
> Bruno
>
>
> On 17/07/14 10:14, noreply@xxxxxxxxxxxxx wrote:
>
> ------------------------------------------------------------
> revno: 4086
> committer: Anton Gladky <gladky.anton@xxxxxxxxx>
> timestamp: Thu 2014-07-17 08:34:00 +0200
> message:
>   Disable reusing of removed body ids.
>
>   Some change in BodyContainer. Previously the ids of removed
>   bodies could be reused by newly created particles. It caused
>   some problems, for instance, by saving in VTK file and building
>   pathlines of them in ParaView.
>
>   Also it could lead to some unexpected behaviour during intensive
>   removal/adding particles.
> modified:
>   core/BodyContainer.cpp
>   core/BodyContainer.hpp
>
>
> --
> lp:yade
> https://code.launchpad.net/~yade-pkg/yade/git-trunk
>
> Your team Yade developers is subscribed to branch lp:yade.
> To unsubscribe from this branch go to
> https://code.launchpad.net/~yade-pkg/yade/git-trunk/+edit-subscription
>
>
>
> _______________________________________________
> Mailing list: https://launchpad.net/~yade-dev
> Post to     : yade-dev@xxxxxxxxxxxxxxxxxxx
> Unsubscribe : https://launchpad.net/~yade-dev
> More help   : https://help.launchpad.net/ListHelp
>
>
>
> --
> _______________
> Bruno Chareyre
> Associate Professor
> ENSE³ - Grenoble INP
> Lab. 3SR
> BP 53
> 38041 Grenoble cedex 9
> Tél : +33 4 56 52 86 21
> Fax : +33 4 76 82 70 43
> ________________
>
>
> _______________________________________________
> Mailing list: https://launchpad.net/~yade-dev
> Post to     : yade-dev@xxxxxxxxxxxxxxxxxxx
> Unsubscribe : https://launchpad.net/~yade-dev
> More help   : https://help.launchpad.net/ListHelp
>