yade-dev team mailing list archive

[Bruno Chareyre <bruno.chareyre@xxxxxxxxxxx>]

It never hurts to comment a little after a commit. Thanks.
B


On 09/10/14 01:28, Jerome Duriez wrote:
> Hi,
>
> Do not know if this mail is really necessary, but, as you might see, I changed the behaviour of porosity() function. Previous usage is still possible and should lead to unchanged result, and a new usage (not passing the volume value as parameter for aperiodic case) is now also possible.
>
> Compilation involves one warning, that is not really directly related to these changes, since it concerns an "include" in _utils.cpp (this file being involved by this commit) that already existed.
>
> If comments are still necessary after this mail, they are welcome.
>
> Jerome 
>
> PS : at least, writing this mail reminds me I did not change the doc of the function.. Commit coming soon
>
> ________________________________________
> From: Yade-dev [yade-dev-bounces+jerome.duriez=ucalgary.ca@xxxxxxxxxxxxxxxxxxx] on behalf of noreply@xxxxxxxxxxxxx [noreply@xxxxxxxxxxxxx]
> Sent: October 8, 2014 5:02 PM
> To: Yade developers
> Subject: [Yade-dev] [Branch ~yade-pkg/yade/git-trunk] Rev 4189: porosity() function infers now a volume value for non-periodic cases, rather than throwing an err...
>
> ------------------------------------------------------------
> revno: 4189
> committer: jduriez <jerome.duriez@xxxxxxxxxxx>
> timestamp: Wed 2014-10-08 14:07:22 -0600
> message:
>   porosity() function infers now a volume value for non-periodic cases, rather than throwing an error. Positiv volume values eventually passed as argument override this inferred value
> modified:
>   pkg/dem/Shop_01.cpp
>
>
> --
> lp:yade
> https://code.launchpad.net/~yade-pkg/yade/git-trunk
>
> Your team Yade developers is subscribed to branch lp:yade.
> To unsubscribe from this branch go to https://code.launchpad.net/~yade-pkg/yade/git-trunk/+edit-subscription
>
> _______________________________________________
> Mailing list: https://launchpad.net/~yade-dev
> Post to     : yade-dev@xxxxxxxxxxxxxxxxxxx
> Unsubscribe : https://launchpad.net/~yade-dev
> More help   : https://help.launchpad.net/ListHelp
>
>
>


-- 
_______________
Bruno Chareyre
Associate Professor
ENSE³ - Grenoble INP
Lab. 3SR
BP 53
38041 Grenoble cedex 9
Tél : +33 4 56 52 86 21
Fax : +33 4 76 82 70 43
________________