← Back to team overview

yade-dev team mailing list archive

Shop::aabbExtrema() : from boost::python::tuple return type to std::vector<Vector3r> ?

 

Hi again,

I would like changing in pkg/dem/Shop*pp the py::tuple aabbExtrema() [*] to std::vector<Vector3r>aabbExtrema() (keeping obviously the Python exposure).


I think this would

- make the Shop C++ files one (small) step closer from the ideal situation discussed at https://www.mail-archive.com/yade-dev@xxxxxxxxxxxxxxxxxxx/msg13308.html

- thus avoiding the back and forth Python-C++ boost conversions in all C++ uses of aabbExtrema() e.g. [**]

- help me solving easily https://bugs.launchpad.net/yade/+bug/1764424 ;-) (thanks Jan for suggestion)

- change (I guess, after py/wrapper/customConverters.cpp) from the user's side the aabbExtrema() value (after typed in YADE terminal) from a tuple to a list...


Thoughts ?

Jérôme

[*] https://github.com/yade/trunk/blob/master/pkg/dem/Shop.hpp#L165 and https://github.com/yade/trunk/blob/master/pkg/dem/Shop_02.cpp#L874 [**] https://github.com/yade/trunk/blob/master/pkg/dem/Shop_02.cpp#L352 and L353

------
Chargé de Recherche / Research Associate
Irstea, RECOVER
3275 route de Cezanne – CS 40061 13182 Aix-en-Provence Cedex 5 FRANCE
+33 (0)4 42 66 99 21



Follow ups