yade-dev team mailing list archive

["Janek Kozicki (yade)" <jkozicki-yade@xxxxxxxxx>]

Bruno Chareyre said:     (by the date of Tue, 10 Mar 2020 20:42:08 +0100)
> Wow, thanks a ton for clarifying. Recently I was wondering why dragging
> with mouse did not work like before... I'll check.

OK, great! Please push the fix to
https://gitlab.com/yade-dev/trunk/-/merge_requests/438 
:-))




> Thanks
> Bruno
> 
> Le mar. 10 mars. 2020 20:28, Janek Kozicki (yade) <jkozicki-yade@xxxxxxxxx>
> a écrit :
> 
> > Bruno Chareyre said:     (by the date of Tue, 10 Mar 2020 13:10:24 +0100)
> > > That's what puzzled me in the first place. So deeply that I didn't dare
> > > replying to the question. :)
> >
> > Ah sorry, here's exactly what I meant:
> >
> > qt5/GLViewer.cpp, function postSelection() was written by Anton in
> > 2015-06-26
> >
> > qt4/GLViewer.cpp, function postSelection() was changed by Bruno in
> > 2017-05-24
> >
> > hm,hm.. Bruno, did you fix something in 2017 in postSelection? Something
> > about
> >
> >         Omega::instance().getScene()->selectedBody = -1;
> >
> > And maybe at that time you were using qt4? And you were playing with
> > moving bodies around?
> >
> > If so, then maybe the "correct" version of this function is rather in qt4
> > directory?
> >
> > > Yes I think we can drop Qt4.
> > > Back to Ubuntu16 Qt5 is available.
> >
> > OK, great. That (first clang-format) merge request about QT does just
> > that. It reformats the directory and removes qt4 directory.
> >
> > However currently in tha MR there is postSelection() from qt5 version
> > by Anton from 2015-06-26. We can change that if you want :)
> >
> > best regards
> > Janek
> >
> >
> > PS: here's the full (clang-formatted) snippet:
> >
> > qt5, Anton, year 2015:
> >
> >         if (selection < 0) {
> >                 if (last >= 0) {
> >                         Body::byId(Body::id_t(last))->state->blockedDOFs =
> > initBlocked;
> >                         last                                             =
> > -1;
> >                         Omega::instance().getScene()->selectedBody       =
> > -1;
> >                 }
> >                 if (isMoving) {
> >                         displayMessage("Moving finished");
> >                         mouseMovesCamera();
> >                         isMoving                                   = false;
> >                         Omega::instance().getScene()->selectedBody = -1;
> >                 }
> >                 return;
> >         }
> >
> > and qt4, Bruno, year 2017:
> >
> >         if (selection < 0) {
> >                 Omega::instance().getScene()->selectedBody = -1;
> >                 if (last >= 0) {
> >                         Body::byId(Body::id_t(last))->state->blockedDOFs =
> > initBlocked;
> >                         last                                             =
> > -1;
> >                 }
> >                 if (isMoving) {
> >                         displayMessage("Moving finished");
> >                         mouseMovesCamera();
> >                         isMoving = false;
> >                 }
> >                 return;
> >         }
> >
> > Bruno's code is shorter by one line and the only difference is that
> > selectedBody = -1; is done alaways, not just inside if(…).
> >
> > Sorry about writing so much about single line. I simply compared the two
> > dirs,
> > and saw just this one difference between the two :)
> >
> >
> >
> > --
> > Janek Kozicki, PhD. DSc. Arch. Assoc. Prof.
> > Gdańsk University of Technology
> > Faculty of Applied Physics and Mathematics
> > Department of Theoretical Physics and Quantum Information
> > --
> > http://yade-dem.org/
> > http://pg.edu.pl/jkozicki (click English flag on top right)
> >
> >
> >


-- 
--
Janek Kozicki, PhD. DSc. Arch. Assoc. Prof.
Gdańsk University of Technology
Faculty of Applied Physics and Mathematics
Department of Theoretical Physics and Quantum Information
--
http://yade-dem.org/
http://pg.edu.pl/jkozicki (click English flag on top right)