yade-users team mailing list archive

[Anton Gladky <question245682@xxxxxxxxxxxxxxxxxxxxx>]

Question #245682 on Yade changed:
https://answers.launchpad.net/yade/+question/245682

Anton Gladky posted a new comment:
Hi Luc,

glad, that you solved it. Some notes about your pull request.

1) Is it OK for you, if i put all LBM-stuff into the pkg/LBM? I think,
our pkg/common and pkg/dem are overloaded and from my point of
view it is better to do it.
2) Please, try to provide a couple of simple examples. Without them
any engine is useless.
3) The most important. You declare the license for your files GPL-3+,
but the rest of the code is licensed under GPL-2+. I would strongly escape
such license mixing. Please, try to talk to all contributors of this code
and relicense it under GPL-2+.

Thanks for contribution!

Anton


2014-03-20 19:01 GMT+01:00 Luc Sibille <question245682@xxxxxxxxxxxxxxxxxxxxx>:
> Question #245682 on Yade changed:
> https://answers.launchpad.net/yade/+question/245682
>
>     Status: Answered => Solved
>
> Luc Sibille confirmed that the question is solved:
> touch path/to/src/CmakelLst.txt have no effect.
> I removed  /trunk/CMakeCache.txt (I imagine it was there because I made a mistake once by compiling Yade from the trunk dir. and not from the build dir. ?). Now it works fine, when I enable the option ENABLE_LBMFLOW at the cmake step, this option is on in  /build/CMakeCache.txt.
>
> Thanks for your help Anton, consequently I have just committed the LBM
> engine.
>
> Luc

-- 
You received this question notification because you are a member of
yade-users, which is an answer contact for Yade.