yahoo-eng-team team mailing list archive

Thread
Date

[Bug 1100042] Re: Openrc generation escapes special characters

To: yahoo-eng-team@xxxxxxxxxxxxxxxxxxx
From: Thierry Carrez <thierry.carrez+lp@xxxxxxxxx>
Date: Thu, 21 Feb 2013 09:03:14 -0000
Reply-to: Bug 1100042 <1100042@xxxxxxxxxxxxxxxxxx>
Sender: bounces@xxxxxxxxxxxxx

** Changed in: horizon
       Status: Fix Committed => Fix Released

-- 
You received this bug notification because you are a member of Yahoo!
Engineering Team, which is subscribed to OpenStack Dashboard (Horizon).
https://bugs.launchpad.net/bugs/1100042

Title:
  Openrc generation escapes special characters

Status in OpenStack Dashboard (Horizon):
  Fix Released

Bug description:
  When special characters are used in tenant names, horizon escapes them
  when generating openrc.sh  for example & is written as &amp;

  A first effort to fix this was made in this review[0] but as Gabriel
  pointed out, it turns out to be a security issue. That for, this
  review was reverted and a new one[1] was created as a work in progress
  in order to find a good and secure way to fix this.

  I guess the main 2 options are:

  1) We don't allow special characters to be input 
  2) We allow just a set of special characters

  Hopefully, we can come out with a better way to fix this.

  [0] https://review.openstack.org/#/c/19672/

  [1] https://review.openstack.org/#/c/19740/

To manage notifications about this bug go to:
https://bugs.launchpad.net/horizon/+bug/1100042/+subscriptions