yahoo-eng-team team mailing list archive
-
yahoo-eng-team team
-
Mailing list archive
-
Message #00904
[Bug 999307] Re: _is_opt_registered does identity check
** Changed in: nova
Status: In Progress => Fix Released
--
You received this bug notification because you are a member of Yahoo!
Engineering Team, which is subscribed to OpenStack Compute (nova).
https://bugs.launchpad.net/bugs/999307
Title:
_is_opt_registered does identity check
Status in OpenStack Compute (Nova):
Fix Released
Status in openstack-common:
Fix Released
Bug description:
When using _is_opt_registered (of cfg) it seems like there is a
identity check that happens here instead of an equality check.
In glance, it was suggested to define the options inside a function,
and then register the opt when that function is entered, this of
course makes the opt registration blow up, since the option will not
be "identically" the same (due to a previous function call occurring
with a different opt, that is equivalent but not identical).
This also will happen if opts are defined inside classes (ie anywhere
not globally) and that class is constructed twice or a function that
defines them is called twice (thus causing duplication option errors).
Possible this line:
if opts[opt.dest]['opt'] is not opt:
Should use equality (or check on the names??)
To manage notifications about this bug go to:
https://bugs.launchpad.net/nova/+bug/999307/+subscriptions