← Back to team overview

yahoo-eng-team team mailing list archive

[Bug 1156840] Re: tests should use identity_controller rather than identity_api

 

I agree that the *_api convention is not super helpful, but identity_api
is actually a reference to the instantiated driver, not a reference to
the identity manager or the controller. Renaming those references to
*_controller would actually be even more misleading. We also have tests
against both managers and controller directly.

catalog_api <-- driver reference (test_backend.py)
catalog_man <-- manager reference (test_backend.py)
self.controller <-- auth controller reference (test_auth.py)

** Changed in: keystone
       Status: New => Invalid

-- 
You received this bug notification because you are a member of Yahoo!
Engineering Team, which is subscribed to Keystone.
https://bugs.launchpad.net/bugs/1156840

Title:
  tests should use identity_controller rather than identity_api

Status in OpenStack Identity (Keystone):
  Invalid

Bug description:
  Currently most of the test code uses self.identity_api =
  identity.Manager() in some fashion or another. This should be renamed
  to self.identity_controller since the Manager just creates an instance
  of the backend's controller.

To manage notifications about this bug go to:
https://bugs.launchpad.net/keystone/+bug/1156840/+subscriptions