← Back to team overview

yahoo-eng-team team mailing list archive

[Bug 1158037] Re: Cant add security group to instance

 

Reviewed:  https://review.openstack.org/25620
Committed: http://github.com/openstack/horizon/commit/293e1c304700e6cf48f73bf2208083fbd68d9505
Submitter: Jenkins
Branch:    milestone-proposed

commit 293e1c304700e6cf48f73bf2208083fbd68d9505
Author: Kieran Spear <kispear@xxxxxxxxx>
Date:   Thu Mar 21 16:50:29 2013 +1100

    Fix adding security groups to an existing instance
    
    Commit 4c34f5f1e8c66e4a865cf7996b283509feb91b71 introduced a
    regression making it impossible to add a security group to
    an existing instance.
    
    In the javascript membership module, make sure new members are still
    assigned the default role even if the role dropdown is not displayed
    (as is the case for the instance security group add/remove view).
    
    Fixes bug 1158037.
    
    Change-Id: I986f7296e97a08d5e9141fe0739d4e028e066fc1
    (cherry picked from commit 64c0ddfa7a5189d4523a31d78cd97dc1ea2151a1)


** Changed in: horizon
       Status: Fix Committed => Fix Released

-- 
You received this bug notification because you are a member of Yahoo!
Engineering Team, which is subscribed to OpenStack Dashboard (Horizon).
https://bugs.launchpad.net/bugs/1158037

Title:
  Cant add security group to instance

Status in OpenStack Dashboard (Horizon):
  Fix Released

Bug description:
  Running Horizon commit f95dd004dc4b0c8f52f934c8669fcbd7ad584fe4.

  Under Instances when you edit an instance security group , you can
  remove the security group from a running instances but you can not add
  any security group back to the instance.

  The operation returns a success but going back to edit the security
  group you can see that it never applies.

  Watching the nova-api.log the actual call to add the security group
  never comes through. The call to remove is clearly visible.

  Btw, this used to work in Grizzly-2.

  The problem seems to be in one of the .js files. To verify this, I
  copied the .js files from a working release to the above commit and I
  can now add the security groups back to instances.

  Thanks.

To manage notifications about this bug go to:
https://bugs.launchpad.net/horizon/+bug/1158037/+subscriptions