← Back to team overview

yahoo-eng-team team mailing list archive

[Bug 1148372] Re: edit flavor deletes the flavor if special char is used

 

Reviewed:  https://review.openstack.org/25621
Committed: http://github.com/openstack/horizon/commit/a4ba8e14a68e88887a94ae73f42e36b7bfede7f8
Submitter: Jenkins
Branch:    milestone-proposed

commit a4ba8e14a68e88887a94ae73f42e36b7bfede7f8
Author: Lin Hua Cheng <lin-hua.cheng@xxxxxx>
Date:   Fri Mar 22 16:57:45 2013 -0700

    Add flavor name regex validation to match nova.
    
    Fixes bug 1148372
    
    Change-Id: Ia1f4d974ddac6cd22c0b8979e98b2ea8f31deb21
    (cherry picked from commit a1012242d7e07c326a485d33371814be9892e1a1)


** Changed in: horizon
       Status: Fix Committed => Fix Released

-- 
You received this bug notification because you are a member of Yahoo!
Engineering Team, which is subscribed to OpenStack Dashboard (Horizon).
https://bugs.launchpad.net/bugs/1148372

Title:
  edit flavor deletes the flavor if special char is used

Status in OpenStack Dashboard (Horizon):
  Fix Released

Bug description:
  Steps to reproduce:
  1. Go to Syspanel > Flavors
  2. Edit an existing flavor
  3. Edit the name field to 'bug()'
  4. Click Save

  Current result:
  The dialog opens again and says Error: There was an error submitting the form. Please try again.
  After refreshing the page the flavor got deleted and isn't seen anymore

  Expected result:
  Save correctly even if there is a ( in the name or show a proper error to the user.

  Wasn't sure yet if it's a bug in nova. why shouldn't a name be
  supported which contains ( ? We currently also support spaces.

  Additional info:
  The following characters are also known to cause this issue %* , probably a lot more but didn't test those.

  This bug also applies to create flavor, as create flavor also just
  shows Error submitting form when invalid char is being used. This is
  because edit does a Delete flavor first and then a Create Flavor.

To manage notifications about this bug go to:
https://bugs.launchpad.net/horizon/+bug/1148372/+subscriptions