yahoo-eng-team team mailing list archive

Thread
Date

[Bug 1107721] Re: while adding/removing security groups to instance, checking power state of instance is not required

To: yahoo-eng-team@xxxxxxxxxxxxxxxxxxx
From: Thierry Carrez <thierry.carrez+lp@xxxxxxxxx>
Date: Wed, 29 May 2013 10:18:51 -0000
Reply-to: Bug 1107721 <1107721@xxxxxxxxxxxxxxxxxx>
Sender: bounces@xxxxxxxxxxxxx

** Changed in: nova
       Status: Fix Committed => Fix Released

** Changed in: nova
    Milestone: None => havana-1

-- 
You received this bug notification because you are a member of Yahoo!
Engineering Team, which is subscribed to OpenStack Compute (nova).
https://bugs.launchpad.net/bugs/1107721

Title:
  while adding/removing security groups to instance, checking power
  state of instance is not required

Status in OpenStack Compute (Nova):
  Fix Released

Bug description:
  For instacne in non-running state, unable to add/remove security group
  due to below conditon.

  $ compute/api.py:

      def add_to_instance(self, context, instance, security_group_name):
             .....
             if instance['power_state'] != power_state.RUNNING: <<<<<
                   raise exception.InstanceNotRunning(instance_id=instance_uuid)
             ....

     def remove_from_instance(self, context, instance, security_group_name):
             .....
             if instance['power_state'] != power_state.RUNNING: <<<<<
                   raise exception.InstanceNotRunning(instance_id=instance_uuid)
             ....

  Is it required?

To manage notifications about this bug go to:
https://bugs.launchpad.net/nova/+bug/1107721/+subscriptions