yahoo-eng-team team mailing list archive

[Thierry Carrez <thierry.carrez+lp@xxxxxxxxx>]

** Changed in: neutron
       Status: Fix Committed => Fix Released

-- 
You received this bug notification because you are a member of Yahoo!
Engineering Team, which is subscribed to neutron.
https://bugs.launchpad.net/bugs/1208716

Title:
  NEC Plugin: Useless and wrong comments

Status in OpenStack Neutron (virtual network service):
  Fix Released

Bug description:
  There are useless and wrong comments in NEC Plugin.

  1)
  neutron/plugins/nec/nec_plugin.py:
  232
  233     # Quantm Plugin Basic methods
  234

  NEC Plugin used to have two types of method definitions; core(network and port) and packet filters.
  This comment point  basic/core methods, but  we don't need this because all packet filter methods are moved to other file.

  
  2)
  neutron/tests/unit/nec/test_nec_plugin.py:
   80         self._set_nec_ini()
   81         super(NecPluginV2TestCase, self).setUp(self._plugin_name)
   82         # NOTE: `test_config' is global, and most tests don't set
   83         # test_config['config_files'] but read this in setUp().
   84         # So clean test_config['config_files'] ASAP, to avoid side effects
   85         # on other tests which are running at the same time.
   86         self._clean_nec_ini()

  This is a misunderstanding about parallel testing. Testr forks
  subprocess to run tests, so there are no side effects to other
  processes.

To manage notifications about this bug go to:
https://bugs.launchpad.net/neutron/+bug/1208716/+subscriptions