yahoo-eng-team team mailing list archive
-
yahoo-eng-team team
-
Mailing list archive
-
Message #04998
[Bug 1006725] Re: Incorrect error returned during Create Image and multi byte characters used for Image name
Seems to work in the latest code in master. Feel free to reopen if you
think further changes are needed.
[rbryant@devstack devstack(master)]$ nova image-create test "ಠ_ರೃ"
[rbryant@devstack devstack(master)]$ nova image-list
+--------------------------------------+---------------------------------+--------+--------------------------------------+
| ID | Name | Status | Server |
+--------------------------------------+---------------------------------+--------+--------------------------------------+
| d7e2a05c-3dd9-49b1-9e35-e31805280ff4 | cirros-0.3.1-x86_64-uec | ACTIVE | |
| 83cb17cc-5a7f-42bc-87c1-8c49100b2c93 | cirros-0.3.1-x86_64-uec-kernel | ACTIVE | |
| db525ca4-0bc3-4229-8c4a-b23799475ead | cirros-0.3.1-x86_64-uec-ramdisk | ACTIVE | |
| fb8fe8d6-9934-474e-8ad6-61bc83d7e39f | ಠ_ರೃ | ACTIVE | 70dabb27-e733-46ab-890a-f714d3bb504d |
+--------------------------------------+---------------------------------+--------+--------------------------------------+
[rbryant@devstack tempest(master)]$ nosetests -sv tempest.api.compute.images.test_images_oneserver.py:ImagesOneServerTestJSON.test_create_image_specify_multibyte_character_image_name
nose.config: INFO: Ignoring files matching ['^\\.', '^_', '^setup\\.py$']
tempest.api.compute.images.test_images_oneserver.ImagesOneServerTestJSON.test_create_image_specify_multibyte_character_image_name[gate,negative] ... ok
----------------------------------------------------------------------
Ran 1 test in 53.895s
OK
[rbryant@devstack tempest(master)]$ git diff tempest/api/compute/
diff --git a/tempest/api/compute/images/test_images_oneserver.py b/tempest/api/compute/images/test_images_onese
index 06e9ab2..7d225e2 100644
--- a/tempest/api/compute/images/test_images_oneserver.py
+++ b/tempest/api/compute/images/test_images_oneserver.py
@@ -64,14 +64,12 @@ class ImagesOneServerTestJSON(base.BaseComputeTest):
cls.alt_manager = clients.AltManager()
cls.alt_client = cls.alt_manager.images_client
- @testtools.skip("Skipped until the Bug #1006725 is resolved.")
@attr(type=['negative', 'gate'])
def test_create_image_specify_multibyte_character_image_name(self):
# Return an error if the image name has multi-byte characters
snapshot_name = rand_name('\xef\xbb\xbf')
- self.assertRaises(exceptions.BadRequest,
- self.client.create_image, self.server['id'],
- snapshot_name)
+ resp, body = self.client.create_image(self.server['id'], snapshot_name)
+ self.assertEqual(202, resp.status)
@attr(type=['negative', 'gate'])
def test_create_image_specify_invalid_metadata(self):
** Changed in: nova
Status: New => Invalid
** Also affects: tempest
Importance: Undecided
Status: New
--
You received this bug notification because you are a member of Yahoo!
Engineering Team, which is subscribed to OpenStack Compute (nova).
https://bugs.launchpad.net/bugs/1006725
Title:
Incorrect error returned during Create Image and multi byte characters
used for Image name
Status in OpenStack Compute (Nova):
Invalid
Status in Tempest:
New
Bug description:
Our tempest tests that checks for 400 Bad Request return code fails
with a ComputeFault instead.
Pass multi-byte character image name during Create Image
Actual Response Code: ComputeFault, 500
Expected Response Code: 400 Bad Request
Return an error if the server name has a multi-byte character ... FAIL
======================================================================
FAIL: Return an error if the server name has a multi-byte character
----------------------------------------------------------------------
Traceback (most recent call last):
File "/opt/stack/tempest/tests/test_images.py", line 251, in test_create_image_specify_multibyte_character_server_name
self.fail("Should return 400 Bad Request if multi byte characters"
AssertionError: Should return 400 Bad Request if multi byte characters are used for image name
-------------------- >> begin captured logging << --------------------
tempest.config: INFO: Using tempest config file /opt/stack/tempest/etc/tempest.conf
tempest.common.rest_client: ERROR: Request URL: http://10.2.3.164:8774/v2/1aeac1cfbfdd43c2845b2cb3a4f15790/images/24ceff93-1af3-41ab-802f-9fc4d8b90b69
tempest.common.rest_client: ERROR: Request Body: None
tempest.common.rest_client: ERROR: Response Headers: {'date': 'Thu, 31 May 2012 06:02:33 GMT', 'status': '404', 'content-length': '62', 'content-type': 'application/json; charset=UTF-8', 'x-compute-request-id': 'req-7a15d284-e934-47a1-87f4-7746e949c7a2'}
tempest.common.rest_client: ERROR: Response Body: {"itemNotFound": {"message": "Image not found.", "code": 404}}
tempest.common.rest_client: ERROR: Request URL: http://10.2.3.164:8774/v2/1aeac1cfbfdd43c2845b2cb3a4f15790/servers/ecb51dfb-493d-4ef8-9178-1adc3d96a04d/action
tempest.common.rest_client: ERROR: Request Body: {"createImage": {"name": "\ufeff43802479847"}}
tempest.common.rest_client: ERROR: Response Headers: {'date': 'Thu, 31 May 2012 06:02:44 GMT', 'status': '500', 'content-length': '128', 'content-type': 'application/json; charset=UTF-8', 'x-compute-request-id': 'req-1a9505f5-4dfc-44e7-b04a-f8daec0f956e'}
tempest.common.rest_client: ERROR: Response Body: {u'computeFault': {u'message': u'The server has either erred or is incapable of performing the requested operation.', u'code': 500}}
--------------------- >> end captured logging << ---------------------
To manage notifications about this bug go to:
https://bugs.launchpad.net/nova/+bug/1006725/+subscriptions