yahoo-eng-team team mailing list archive

[Thierry Carrez <thierry.carrez+lp@xxxxxxxxx>]

** Changed in: nova
       Status: Fix Committed => Fix Released

-- 
You received this bug notification because you are a member of Yahoo!
Engineering Team, which is subscribed to OpenStack Compute (nova).
https://bugs.launchpad.net/bugs/1210659

Title:
  xenapi: Fix download_handler fallback

Status in OpenStack Compute (Nova):
  Fix Released

Bug description:
  In order to make image-download a bit more robust, we attempt to
  download from a preferred handler and if that fails, we fall back to a
  default handler.

  If the preferred handler *is* the default-handler, then we should just
  raise the exception instead of retrying.

  The existing code was checking to see with whether the handler
  *instance* compared as equal to the default-handler *instance*. Since
  the two objects are instantiated separately, they'll be different
  objects, so never compare as equal.

  The correct check is to see if the handler is an instance of the
  default handler's class.

To manage notifications about this bug go to:
https://bugs.launchpad.net/nova/+bug/1210659/+subscriptions